https://bugzilla.redhat.com/show_bug.cgi?id=824393 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #3 from Petr Pisar <ppisar@xxxxxxxxxx> --- Spec file changes: --- perl-Devel-CallParser.spec.old 2012-05-24 09:02:35.000000000 -0400 +++ perl-Devel-CallParser.spec 2012-05-29 07:32:34.000000000 -0400 @@ -12,6 +12,7 @@ BuildRequires: perl(DynaLoader::Functions) BuildRequires: perl(Exporter) BuildRequires: perl(parent) +BuildRequires: perl(Module::Build) # Tests BuildRequires: perl(Data::Alias) >= 1.13 BuildRequires: perl(Devel::Declare) >= 0.006004 @@ -20,17 +21,19 @@ BuildRequires: perl(File::Spec) BuildRequires: perl(IO::File) >= 1.03 BuildRequires: perl(Lexical::Sub) -BuildRequires: perl(Module::Build) BuildRequires: perl(Test::More) -BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod) >= 1.00 BuildRequires: perl(Test::Pod::Coverage) +Requires: perl(Devel::CallChecker) >= 0.002 Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Conflicts: perl(Data::Alias) < 1.13 +Conflicts: perl(Devel::Declare) < 0.006004 %{?perl_default_filter} %description This module provides a C API, for XS modules, concerned with custom -parsing. It is centred around the function cv_set_call_parser, which allows +parsing. It is centered around the function cv_set_call_parser, which allows XS code to attach a magical annotation to a Perl subroutine, resulting in resolvable calls to that subroutine having their arguments parsed by arbitrary C code. (This is a more conveniently structured facility than the > TODO: Move the `perl(Module::Build)' before #Tests. It's need to run Build.PL > at build-time. +BuildRequires: perl(Module::Build) # Tests Ok. > TODO: Conflict with `perl(Data::Alias) < 1.13' (Build.PL:150). > TODO: Conflict with `perl(Devel::Declare) < 0.006004)' (Build.PL:151). +Conflicts: perl(Data::Alias) < 1.13 +Conflicts: perl(Devel::Declare) < 0.006004 Ok. > TODO: Qualify `perl(Test::Pod)' build-require with `>= 1.00' (t/pod_syn.t:5). -BuildRequires: perl(Test::Pod) +BuildRequires: perl(Test::Pod) >= 1.00 Ok. > > TODO: Qualify `perl(Test::Pod::Coverage)' build-require with `>= 1' > > (t/pod_cvg.t:6). > There is not specified version of library. Because '1' is return value for > eval when 'use' passed, if I understand it correctly. You are right. I missed the semicolon. Ok. > TODO: Change `centred' spelling to the American one. $ rpmlint perl-Devel-CallParser.spec ../SRPMS/perl-Devel-CallParser-0.001-1.fc18.src.rpm ../RPMS/x86_64/perl-Devel-CallParser-* perl-Devel-CallParser.src: W: spelling-error %description -l en_US cv -> CV, xv, cc perl-Devel-CallParser.x86_64: W: spelling-error %description -l en_US cv -> CV, xv, cc 3 packages and 1 specfiles checked; 0 errors, 2 warnings. Ok. > FIX: Run-require `perl(Devel::CallChecker) >= 0.002' (META.yml:37). $ rpm -q --requires -p ../RPMS/x86_64/perl-Devel-CallParser-0.001-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 libc.so.6()(64bit) 1 perl(Devel::CallChecker) >= 0.001 1 perl(Devel::CallChecker) >= 0.002 1 perl(DynaLoader::Functions) >= 0.000 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Ok. TODO: You can filter the underspecifed dependency `perl(Devel::CallChecker) >= 0.001' now. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4111639). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' item before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review