https://bugzilla.redhat.com/show_bug.cgi?id=812587 --- Comment #2 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source tar ball is original. Ok. Summary verified from lib/FusionInventory/Agent/Task/Deploy.pm. Ok. License verified from README and LICENSE. Ok. URL and Source0 are usable. Ok. No XS code. noarch BuildArch is Ok. FIX: Build- and run-require `perl(POE::Component::Client::TCP)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9). FIX: Build-require `perl(File::Which)' (Makefile.PL:13). TODO: Build-require `perl(base)' (lib/FusionInventory/Agent/Task/Deploy.pm:8). FIX: Build-require `perl(LWP)' (lib/FusionInventory/Agent/Task/Deploy.pm:11). FIX: Build-require `perl(Compress::Zlib)' (lib/FusionInventory/Agent/Task/Deploy/Datastore/WorkDir.pm:7). TODO: Build-require `perl(File::Path)' (lib/FusionInventory/Agent/Task/Deploy/Datastore/WorkDir.pm:9). TODO: Build-require `perl(Exporter)' (lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:5). FIX: Build-require `perl(UNIVERSAL::require)' (lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm:10). FIX: Build-require `perl(File::Spec)' (lib/FusionInventory/Agent/Task/Deploy/Datastore.pm:8). FIX: Build-require `perl(HTTP::Request::Common)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:7). FIX: Build-require `perl(Net::IP)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:8). FIX: Build-require `perl(POE)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9). FIX: Build-require `perl(Cwd)' (lib/FusionInventory/Agent/Task/Deploy/ActionProcessor.pm:6). FIX: Build-require `perl(HTTP::Request)' (lib/FusionInventory/Agent/Task/Deploy/File.pm:10). FIX: Build-require `perl(Test::More)' (t/06spelling.t:6). FIX: Build-require `perl(HTTP::Server::Simple::CGI)' (t/server.t:7). FIX: Build-require `perl(Data::Dumper)' (t/server.t:12). TODO: I can't see why perl(HTTP::Server::Simple::Authen) and perl(CGI) are build-required. The modules are used nowhere. Are they needed? TODO: You can remove the BuildRoot tag and it's cleaning if your are not intent to build this package in EPEL-5. The actions are implicit in newer distributions. TODO: Remove the %defattr from %files section. This is implicit in all distributions. All tests pass. Ok. TODO: Report a bug to upstream about undefined value (Use of uninitialized value in string eq at /builddir/build/BUILD/FusionInventory-Agent-Task-Deploy-2.0.0/blib/lib/FusionInventory/Agent/Task/Deploy/CheckProcessor.pm line 14.). $ rpmlint perl-FusionInventory-Agent-Task-Deploy.spec ../SRPMS/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.src.rpm ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.noarch.rpm drwxr-xr-x 2 root root 0 kvě 29 07:40 /usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0 -rw-r--r-- 1 root root 2250 dub 8 15:07 /usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0/Changes -rw-r--r-- 1 root root 17987 zář 20 2011 /usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0/LICENSE -rw-r--r-- 1 root root 725 bře 18 19:11 /usr/share/doc/perl-FusionInventory-Agent-Task-Deploy-2.0.0/README drwxr-xr-x 2 root root 0 kvě 29 07:40 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy -rw-r--r-- 1 root root 16869 dub 8 15:08 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy.pm drwxr-xr-x 2 root root 0 kvě 29 07:40 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor -rw-r--r-- 1 root root 2243 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor.pm drwxr-xr-x 2 root root 0 kvě 29 07:40 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action -rw-r--r-- 1 root root 2884 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Cmd.pm -rw-r--r-- 1 root root 711 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Copy.pm -rw-r--r-- 1 root root 470 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Delete.pm -rw-r--r-- 1 root root 689 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Mkdir.pm -rw-r--r-- 1 root root 702 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/ActionProcessor/Action/Move.pm -rw-r--r-- 1 root root 2999 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/CheckProcessor.pm drwxr-xr-x 2 root root 0 kvě 29 07:40 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/Datastore -rw-r--r-- 1 root root 2487 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/Datastore.pm -rw-r--r-- 1 root root 2437 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/Datastore/WorkDir.pm -rw-r--r-- 1 root root 1899 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/DiskFree.pm -rw-r--r-- 1 root root 4434 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/File.pm -rw-r--r-- 1 root root 797 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/Job.pm -rw-r--r-- 1 root root 5496 dub 8 15:04 /usr/share/fusioninventory/lib/FusionInventory/Agent/Task/Deploy/P2P.pm -rw-r--r-- 1 root root 1987 kvě 29 07:40 /usr/share/man/man3/FusionInventory::Agent::Task::Deploy.3pm.gz The Fusion Perl modules are private. Non-standard location is Ok. File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.noarch.rpm |sort |uniq -c 1 fusioninventory-agent >= 2.2.0 1 perl(Archive::Extract) 1 perl(base) 1 perl(Compress::Zlib) 1 perl(Cwd) 2 perl(Digest::SHA) 1 perl(English) 1 perl(Exporter) 1 perl(File::Basename) 1 perl(File::Copy::Recursive) 1 perl(File::Glob) 1 perl(File::Path) 1 perl(File::Spec) 1 perl(HTTP::Request) 1 perl(HTTP::Request::Common) 1 perl(JSON) 1 perl(LWP) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(Net::IP) 1 perl(POE) 1 perl(POE::Component::Client::Ping) 1 perl(strict) 1 perl(UNIVERSAL::require) 1 perl(URI::Escape) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 TODO: Do not run-require `perl(Digest::SHA)' explicitly. It's auto-detected. FIX: Run-require `perl(POE::Component::Client::TCP)' (lib/FusionInventory/Agent/Task/Deploy/P2P.pm:9). $ rpm -q --provides -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.noarch.rpm |sort |uniq -c 1 perl-FusionInventory-Agent-Task-Deploy = 2.0.0-2.fc18 The Fusion::* modules are private, thus filtered. Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-FusionInventory-Agent-Task-Deploy-2.0.0-2.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4111625). Ok. Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review