https://bugzilla.redhat.com/show_bug.cgi?id=824949 --- Comment #5 from Matthias Runge <mrunge@xxxxxxxxxxxxxxxxx> --- Some minors: ./common/atoms.c: GPL (v2 or later) ./common/buffer.h: BSD (2 clause) ... ./common/atoms.h: GPL (v2 or later) ./common/buffer.c: BSD (2 clause) License should become: # common/buffer.[ch]: BSD License: GPLv2+ and BSD defattr(....) present in %files doc section. This is OK if packaging for EPEL5. Otherwise not needed. If you're not targeting el5 also, I'd remove that. Could you inspect the desktop-file?: [!]: MUST Package contains a properly installed %{name}.desktop using desktop- file-install file if it is a GUI application. I'd also prefer to get that files section some more explicit (man...) -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review