https://bugzilla.redhat.com/show_bug.cgi?id=824393 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source package is original. Ok. Summary verified from lib/Devel/CallParser.pm. Ok. License verified from lib/Devel/CallParser.pm. Ok. URL and Source0 are usable. Ok. Description verified from lib/Devel/CallParser.pm. Ok. XS code presents. BuildArch is Ok. TODO: Move the `perl(Module::Build)' before #Tests. It's need to run Build.PL at build-time. TODO: Conflict with `perl(Data::Alias) < 1.13' (Build.PL:150). TODO: Conflict with `perl(Devel::Declare) < 0.006004)' (Build.PL:151). TODO: Qualify `perl(Test::Pod)' build-require with `>= 1.00' (t/pod_syn.t:5). TODO: Qualify `perl(Test::Pod::Coverage)' build-require with `>= 1' (t/pod_cvg.t:6). All tests pass. Ok. $ rpmlint perl-Devel-CallParser.spec ../SRPMS/perl-Devel-CallParser-0.001-1.fc18.src.rpm ../RPMS/x86_64/perl-Devel-CallParser-* perl-Devel-CallParser.src: W: spelling-error %description -l en_US centred -> centered, cent red, cent-red perl-Devel-CallParser.src: W: spelling-error %description -l en_US cv -> CV, xv, cc perl-Devel-CallParser.x86_64: W: spelling-error %description -l en_US centred -> centered, cent red, cent-red perl-Devel-CallParser.x86_64: W: spelling-error %description -l en_US cv -> CV, xv, cc 3 packages and 1 specfiles checked; 0 errors, 4 warnings. TODO: Change `centred' spelling to the American one. $ rpm -q -lv -p ../RPMS/x86_64/perl-Devel-CallParser-0.001-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 29 04:51 /usr/lib64/perl5/vendor_perl/Devel -rw-r--r-- 1 root root 14555 May 29 04:51 /usr/lib64/perl5/vendor_perl/Devel/CallParser.pm drwxr-xr-x 2 root root 0 May 29 04:51 /usr/lib64/perl5/vendor_perl/auto/Devel drwxr-xr-x 2 root root 0 May 29 04:51 /usr/lib64/perl5/vendor_perl/auto/Devel/CallParser -rwxr-xr-x 1 root root 18688 May 29 04:51 /usr/lib64/perl5/vendor_perl/auto/Devel/CallParser/CallParser.so drwxr-xr-x 2 root root 0 May 29 04:51 /usr/share/doc/perl-Devel-CallParser-0.001 -rw-r--r-- 1 root root 305 May 20 2011 /usr/share/doc/perl-Devel-CallParser-0.001/Changes -rw-r--r-- 1 root root 1031 May 20 2011 /usr/share/doc/perl-Devel-CallParser-0.001/README -rw-r--r-- 1 root root 5639 May 29 04:51 /usr/share/man/man3/Devel::CallParser.3pm.gz File layout and permissions are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Devel-CallParser-0.001-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(Devel::CallChecker) >= 0.001 1 perl(DynaLoader::Functions) >= 0.000 1 perl(Exporter) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(parent) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) FIX: Run-require `perl(Devel::CallChecker) >= 0.002' (META.yml:37). $ rpm -q --provides -p ../RPMS/x86_64/perl-Devel-CallParser-0.001-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(Devel::CallParser) = 0.001 1 perl-Devel-CallParser = 0.001-1.fc18 1 perl-Devel-CallParser(x86-64) = 0.001-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/x86_64/perl-Devel-CallParser-0.001-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4111440). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review