[Bug 820544] Review Request: libguac-client-rdp - RDP support for guacd

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=820544

--- Comment #12 from Simone Caronni <negativo17@xxxxxxxxx> ---
(In reply to comment #10)
> (In reply to comment #5)
> > (In reply to comment #4)
> > > Why is there the following :
> > > BuildRequires:  libguac-devel%{?_isa} = %{version}
> > > BuildRequires:  cairo-devel%{?_isa}, freerdp-devel%{?_isa} < 1.1
> 
> IMO, isas in these BR's are not useful and would recommend to remove them.

Depending on who's doing the review I got mixed results regarding the ISA'ed
BRs. Some time is necessary to get the package approved, in some cases it's the
opposite.

Since libguac has already been approved with ISA'ed BRs and there's no
difference in building I would leave them in the spec file for uniformity with
all the pieces of the stack.

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]