https://bugzilla.redhat.com/show_bug.cgi?id=817303 Remi Collet <fedora@xxxxxxxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nobody@xxxxxxxxxxxxxxxxx |fedora@xxxxxxxxxxxxxxxxx Flags| |fedora-review? --- Comment #5 from Remi Collet <fedora@xxxxxxxxxxxxxxxxx> --- About [ -f package2.xml ] || mv package.xml package2.xml mv package2.xml %{pear_name}-%{version}/%{name}.xml This is a old hack (yes it works) to ensure than package v2 is used. I often use # package.xml is version 2.0 mv package.xml %{pear_name}-%{version}/%{name}.xml This is not an issue, but make the spec simpler to read. About %clean As you have clean EL-5 stuff (Buildroot, %defattr) you should also remove the %clean section and the rm -rf %{buildroot} in %install I will prefer to move documentation to correct location by fixing the package.xml (temporary hack waiting for upstream fix, see bug #823041) In fact you don't need to requires (nor buildrequires) php-pear(PEAR), the PEAR classes are not used, only the installer. But the Guildelines says you must.. so keep it (I will probably propose a minor update to the PHP Guidelines) > BuildRequires: php-pear >= 1:1.4.9-1.2 > BuildRequires: php-pear(PEAR) The first could be removed (no more older version, even in EPEL) and is a duplicate of the second. Please confirm your fas account (as we have 6 packages approved + this one near to be, I will soon sponsor you). -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review