https://bugzilla.redhat.com/show_bug.cgi?id=738465 Jonas Courteau <rpms@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rpms@xxxxxxxxxxxx --- Comment #2 from Jonas Courteau <rpms@xxxxxxxxxxxx> --- Hi! I can only provide an unofficial review, but here's a few comments: I'd recommend going over the spec file and bringing it more in line with the guidelines here: http://fedoraproject.org/wiki/Packaging:Ruby. Specifically, you'll want to have a BuildRequires against rubygems-devel, and use the provided macros (gem_dir,gem_instdir, and so on). There's also new guidelines in there for the %prep/%build/%install sections. As suggested in those guidelines, you may want to add a %check section. It looks like the gem includes its tests, so: %check pushd .%{gem_instdir} rspec -Ilib spec/ rm -rf spec/ popd should work. (it's also recommended that you don't package the tests unless you need to) Also, to package on fedora 17 or rawhide, the ruby(abi) requirement needs to be updated to 1.9.1 There's also a bunch of whitespace in front of the changelog entry which should be removed. --- Hopefully that helps! Once these things are resolved, I'll run through the full review checklist as well. If anyone is wanting to do other Rubygem-based package reviews, take a look at some of mine - see https://bugzilla.redhat.com/show_bug.cgi?id=823352 and its dependencies. I still need a sponsor too. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review