Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: lsof https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226108 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ruben@xxxxxxxxxxxxxxxx |kzak@xxxxxxxxxx Flag|fedora-review+ |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-04 13:57 EST ------- Hi Karel, Review for release 3: * RPM name is OK * This is the latest version * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * Package is marked as relocatable, please check. (wiki: PackagingGuidelines#RelocatablePackages) * No downloadable source. Please give the full URL in the Source tag. * Preserve timestamps when installing files * Use {?dist} in Release tag Rpmlint is not silent: Source RPM: W: lsof summary-ended-with-dot A utility which lists open files on a Linux/UNIX system. W: lsof invalid-license Free W: lsof no-url-tag W: lsof redundant-prefix-tag W: lsof macro-in-%changelog install rpmlint of lsof: W: lsof summary-ended-with-dot A utility which lists open files on a Linux/UNIX system. W: lsof invalid-license Free W: lsof no-url-tag -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review