https://bugzilla.redhat.com/show_bug.cgi?id=820115 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx --- Comment #1 from Volker Fröhlich <volker27@xxxxxx> --- Please require the base package in the architecture dependent way: http://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package Use global instead of define: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define If you don't want to introduce this package to EPEL 5, remove the buildroot definition, the clean section and the cleaning rm in the install section. Don't use the rm, make or install macro. Just use the plain commands. defattr is no longer necessary. Many of the filenames in bindir are generic. Consider to use a prefix. Since the binaries are 2.9 MB and the library is only 1.6, I suggest to create a libs-sub-package. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review