https://bugzilla.redhat.com/show_bug.cgi?id=823661 Volker Fröhlich <volker27@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |volker27@xxxxxx Blocks| |177841 --- Comment #3 from Volker Fröhlich <volker27@xxxxxx> --- The FAS name is actually chriscowleyunix. You don't seem to have a sponsor, therefore tagging the ticket. The license seems to be GPLv3+, from what I see in lessfsck.c. Please don't mix RPM_BUILD_ROOT and buildroot. Do you plan to bring this package to EPEL 5? If not, several elements are not necessary (buildroot definition, clean section, rm in install section.) Don't require gcc. It is available by default, see: http://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 Don't require tokyocabinet explicitly. Rpm creates this dependency on its own. Since this is a daemon, you'll need a system user to run the daemon as. In Fedora daemons need systemd unit files: http://fedoraproject.org/wiki/Packaging:Systemd Also see http://fedoraproject.org/wiki/Packaging:ScriptletSnippets Looking at lessfs.cfg, /var/lib/lessfs/mta is expected to exist. You must create and own this directory. Please use the name macro in Source. ${version} should be %{version}. I suppose you are aware of the process of becoming a packager? http://fedoraproject.org/wiki/Join_the_package_collection_maintainers Mark the configuration file as such: http://fedoraproject.org/wiki/Packaging:Guidelines#Configuration_files "/usr/bin/mklessfs" from the init script is certainly wrong, as you installed it to /usr/sbin. What is that about? mkdir -p %{buildroot}/data -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review