https://bugzilla.redhat.com/show_bug.cgi?id=825166 Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Review Request: |Review Request: |irssi-notify - Use |irssi-libnotify - Use |libnotify to alert user to |libnotify to alert user to |irssi messages |irssi messages --- Comment #3 from Ankur Sinha (FranciscoD) <sanjay.ankur@xxxxxxxxx> --- (In reply to comment #2) > Before I start reviewing: > > - there's no such project as irssi-notify; did you mean irssi-libnotify? > - you really shouldn't point to svn trunk; if upstream doesn't provide > release tarballs, make one yourself with a date tag or something > - don't provide your own copy of license if upstream doesn't ship it Updated spec/srpm with corrections: http://ankursinha.fedorapeople.org/irssi-libnotify/irssi-libnotify.spec http://ankursinha.fedorapeople.org/irssi-libnotify/irssi-libnotify-0.2.0-2.fc17.src.rpm Thanks :) Ankur -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review