https://bugzilla.redhat.com/show_bug.cgi?id=820561 Terje Røsten <terjeros@xxxxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |terjeros@xxxxxxxxxxxx --- Comment #8 from Terje Røsten <terjeros@xxxxxxxxxxxx> --- Some comments: - the mkdir lines is not needed ( the -D to install will fix dir creation). - could you do a koji scratch build (I think BuildRequires: systemd-units is needed for unitdir macro). - you also need more Requires to let systemctl or chkconfig be available during install: chkconfig: http://fedoraproject.org/wiki/Packaging:SysVInitScript#Initscripts_in_spec_file_scriptlets systemd: Requires(post): systemd-sysv Requires(post): systemd-units Requires(preun): systemd-units Requires(postun): systemd-units - you change between %{name} macro and plain guacd at random, please keep %{name} usage to minimum (if at all). - you also mix install and %{__install} macro, stick to one form only. - don't use .gz in %{_mandir}/man8/%{name}.8.gz let rpm decide compression and just use ...8.* -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review