https://bugzilla.redhat.com/show_bug.cgi?id=823989 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source file is original. Ok. Summary verified from lib/Lexical/Var.pm. Ok. License verified from lib/Lexical/*. Ok. URL and Source0 are usable. Ok. Description verified from README. Ok. XS code presents, BuildArch is Ok. Conflicts verified from Build.PL. Ok. TODO: Build-require `perl(XSLoader)' (lib/Lexical/Var.pm:70). All tests pass. Ok. $ rpmlint perl-Lexical-Var.spec ../SRPMS/perl-Lexical-Var-0.007-1.fc18.src.rpm ../RPMS/x86_64/perl-Lexical-Var-* 3 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/x86_64/perl-Lexical-Var-0.007-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 25 03:49 /usr/lib64/perl5/vendor_perl/Lexical -rw-r--r-- 1 root root 5670 May 25 03:49 /usr/lib64/perl5/vendor_perl/Lexical/Sub.pm -rw-r--r-- 1 root root 7866 May 25 03:49 /usr/lib64/perl5/vendor_perl/Lexical/Var.pm drwxr-xr-x 2 root root 0 May 25 03:49 /usr/lib64/perl5/vendor_perl/auto/Lexical drwxr-xr-x 2 root root 0 May 25 03:49 /usr/lib64/perl5/vendor_perl/auto/Lexical/Var -rwxr-xr-x 1 root root 18560 May 25 03:49 /usr/lib64/perl5/vendor_perl/auto/Lexical/Var/Var.so drwxr-xr-x 2 root root 0 May 25 03:49 /usr/share/doc/perl-Lexical-Var-0.007 -rw-r--r-- 1 root root 4767 Feb 4 03:58 /usr/share/doc/perl-Lexical-Var-0.007/Changes -rw-r--r-- 1 root root 2865 Feb 4 03:58 /usr/share/doc/perl-Lexical-Var-0.007/README -rw-r--r-- 1 root root 4098 May 25 03:49 /usr/share/man/man3/Lexical::Sub.3pm.gz -rw-r--r-- 1 root root 4988 May 25 03:49 /usr/share/man/man3/Lexical::Var.3pm.gz File permissions and layout is Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Lexical-Var-0.007-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(Lexical::SealRequireHints) >= 0.006 1 perl(Lexical::Var) 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(warnings) 1 perl(XSLoader) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Lexical-Var-0.007-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(Lexical::Sub) = 0.007 1 perl(Lexical::Var) = 0.007 1 perl-Lexical-Var = 0.007-1.fc18 1 perl-Lexical-Var(x86-64) = 0.007-1.fc18 Binary provides are Ok. $ resolvedeps f18-build ../RPMS/x86_64/perl-Lexical-Var-0.007-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4100056). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' item before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review