Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: echo-icon-theme https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225715 bdpepple@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|nobody@xxxxxxxxxxxxxxxxx |davidz@xxxxxxxxxx CC| |bdpepple@xxxxxxxxxxxxx Flag| |fedora-review- ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2007-02-04 10:58 EST ------- Good: * Source URL is canonical * Upstream source tarball verified * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * Buildroot has all required elements * All paths begin with macros * All directories are owned by this or other packages * Builds fine in mock. Must Fix: * Should be Requires(postun), not Requires(postub). * rpmlint errors: W: echo-icon-theme macro-in-%changelog _datadir W: echo-icon-theme macro-in-%changelog build W: echo-icon-theme macro-in-%changelog buildroot This should be an easy one to fix. Just %% the macros in the ChangeLog. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review