Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: devhelp https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225684 bdpepple@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|bdpepple@xxxxxxxxxxxxx |mbarnes@xxxxxxxxxx CC| |bdpepple@xxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From bdpepple@xxxxxxxxxxxxx 2007-02-04 10:49 EST ------- Good: * Package name conforms to the Fedora Naming Guidelines * Group Tag is from the official list * All paths begin with macros * Desktop entry is fine * All directories are owned by this or other packages * All necessary BuildRequires listed. * Builds in Mock fine. Must Fix Items: * Missing URL . http://developer.imendio.com/projects/devhelp * Source URL isn't canonical. http://ftp.gnome.org/pub/GNOME/sources/%{name}/%{version}/%{name}-%{version}.bz2 * rpmlint error: E: devhelp postin-without-ldconfig /usr/lib/libdevhelp-1.so.0.0.0 E: devhelp postun-without-ldconfig /usr/lib/libdevhelp-1.so.0.0.0 Minor things to look at, not considered blockers: * rpmlint error: W: devhelp-devel summary-ended-with-dot Library to embed Devhelp in other applications. * Doesn't use preferred buildroot. http://fedoraproject.org/wiki/Packaging/Guidelines#head-f196e7b2477c2f5dd97ef64e8eacddfb517f1aa1 * Unnecessary Requires on gnome-vfs2, gtk2, libglade2, and libgnomeui. The BR on the devel packages should pull these in automatically. http://linux.dell.com/files/fedora/FixBuildRequires/mock-results-core/i386/devhelp-0.12-10.fc7.src.rpm/result/build.log * Duplicate BuildRequires: glib2-devel (by gtk2-devel), libglade2-devel (by libgnomeui-devel), gtk2-devel (by libgnomeui-devel), GConf2-devel (by libgnomeui-devel), gnome-vfs2-devel (by libgnomeui-devel) * Could use the '-disable-static' configure flag, and not even bother building the static libs. * Could just use 'rm -rf $RPM_BUILD_ROOT' to clean the install section for consistency. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review