https://bugzilla.redhat.com/show_bug.cgi?id=823948 --- Comment #1 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source file is original. Ok. Summary verified from lib/Lexical/SealRequireHints.pm. Ok. License verified from lib/Lexical/SealRequireHints.pm. Ok. Description verified from lib/Lexical/SealRequireHints.pm. Ok. URL and Source0 are usable. Ok. XS code presents, BuildArch is Ok. TODO: Do no package useless META.json (installation instructions) and README (copy of POD). TODO: Declare conflict with `perl(B::Hooks::OP::Check) < 0.19' (Build.PL:96, Changes:45). All tests pass. Ok. $ rpmlint perl-Lexical-SealRequireHints.spec ../SRPMS/perl-Lexical-SealRequireHints-0.007-1.fc18.src.rpm ../RPMS/x86_64/perl-Lexical-SealRequireHints-* perl-Lexical-SealRequireHints.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Lexical/SealRequireHints/SealRequireHints.so SealRequireHints.so()(64bit) perl-Lexical-SealRequireHints.x86_64: W: private-shared-object-provides /usr/lib64/perl5/vendor_perl/auto/Lexical/SealRequireHints/SealRequireHints.so SealRequireHints.so()(64bit) perl-Lexical-SealRequireHints-debuginfo.x86_64: E: description-line-too-long C This package provides debug information for package perl-Lexical-SealRequireHints. 3 packages and 1 specfiles checked; 1 errors, 2 warnings. FIX: Filter private libraries from Provides by calling `%{?perl_default_filter}' before %description section. $ rpm -q -lv -p ../RPMS/x86_64/perl-Lexical-SealRequireHints-0.007-1.fc18.x86_64.rpm drwxr-xr-x 2 root root 0 May 24 07:24 /usr/lib64/perl5/vendor_perl/Lexical -rw-r--r-- 1 root root 9451 May 24 07:24 /usr/lib64/perl5/vendor_perl/Lexical/SealRequireHints.pm drwxr-xr-x 2 root root 0 May 24 07:24 /usr/lib64/perl5/vendor_perl/auto/Lexical drwxr-xr-x 2 root root 0 May 24 07:24 /usr/lib64/perl5/vendor_perl/auto/Lexical/SealRequireHints -rwxr-xr-x 1 root root 6088 May 24 07:24 /usr/lib64/perl5/vendor_perl/auto/Lexical/SealRequireHints/SealRequireHints.so drwxr-xr-x 2 root root 0 May 24 07:25 /usr/share/doc/perl-Lexical-SealRequireHints-0.007 -rw-r--r-- 1 root root 4777 Feb 11 06:16 /usr/share/doc/perl-Lexical-SealRequireHints-0.007/Changes -rw-r--r-- 1 root root 1376 Feb 11 06:16 /usr/share/doc/perl-Lexical-SealRequireHints-0.007/META.json -rw-r--r-- 1 root root 2739 Feb 11 06:16 /usr/share/doc/perl-Lexical-SealRequireHints-0.007/README -rw-r--r-- 1 root root 4204 May 24 07:24 /usr/share/man/man3/Lexical::SealRequireHints.3pm.gz File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/x86_64/perl-Lexical-SealRequireHints-0.007-1.fc18.x86_64.rpm |sort |uniq -c 1 libc.so.6()(64bit) 1 libc.so.6(GLIBC_2.2.5)(64bit) 1 perl(:MODULE_COMPAT_5.14.2) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 1 rtld(GNU_HASH) Binary requires are Ok. $ rpm -q --provides -p ../RPMS/x86_64/perl-Lexical-SealRequireHints-0.007-1.fc18.x86_64.rpm |sort |uniq -c 1 perl(Lexical::SealRequireHints) = 0.007 1 perl-Lexical-SealRequireHints = 0.007-1.fc18 1 perl-Lexical-SealRequireHints(x86-64) = 0.007-1.fc18 1 SealRequireHints.so()(64bit) FIX: Do not export private library `SealRequireHints.so()(64bit)'. $ resolvedeps rawhide ../RPMS/x86_64/perl-Lexical-SealRequireHints-0.007-1.fc18.x86_64.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4097615). Ok. Otherwise package is in line with Fedora and Perl packaging guidelines. Please correct all `FIX' issues, consider fixing `TODO' items and provide new spec file. Resolution: Package NOT approved. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review