https://bugzilla.redhat.com/show_bug.cgi?id=823523 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flags|fedora-review? |fedora-review+ --- Comment #4 from Petr Pisar <ppisar@xxxxxxxxxx> --- Source file is original. Ok. Summary verified from lib/syntax.pm. Ok. License verified from lib/syntax.pm and LICENSE. Ok. URL and Source0 are usable. Ok. Description verified from lib/syntax.pm. Ok. No XS code, noarch BuilArch is Ok. TODO: Remove useless files from documentation (dist.ini, README, weaver.ini). TODO: Build-require `perl(lib)' for running tests (t/basic.t:6). TODO: Remove the build-requires for optional tests because they are not used. Release tests terminate before using the modules because of unset RELEASE_TESTING environment variable. Or export the variable for `make test' to proceed the release tests. All tests pass. Ok. $ rpmlint perl-syntax.spec ../SRPMS/perl-syntax-0.004-1.fc18.src.rpm ../RPMS/noarch/perl-syntax-0.004-1.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q -lv -p ../RPMS/noarch/perl-syntax-0.004-1.fc18.noarch.rpm drwxr-xr-x 2 root root 0 May 24 03:54 /usr/share/doc/perl-syntax-0.004 -rw-r--r-- 1 root root 528 May 18 14:47 /usr/share/doc/perl-syntax-0.004/Changes -rw-r--r-- 1 root root 18386 May 18 14:47 /usr/share/doc/perl-syntax-0.004/LICENSE -rw-r--r-- 1 root root 1518 May 18 14:47 /usr/share/doc/perl-syntax-0.004/META.json -rw-r--r-- 1 root root 2095 May 18 14:47 /usr/share/doc/perl-syntax-0.004/README -rw-r--r-- 1 root root 873 May 18 14:47 /usr/share/doc/perl-syntax-0.004/dist.ini -rw-r--r-- 1 root root 294 May 18 14:47 /usr/share/doc/perl-syntax-0.004/weaver.ini -rw-r--r-- 1 root root 2724 May 24 03:54 /usr/share/man/man3/syntax.3pm.gz -rw-r--r-- 1 root root 4346 May 18 14:47 /usr/share/perl5/vendor_perl/syntax.pm File permissions and layout are Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-syntax-0.004-1.fc18.noarch.rpm |sort |uniq -c 1 perl(Carp) 1 perl(Data::OptList) >= 0.104 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(namespace::clean) 1 perl(strict) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 Binary requires are Ok. $ rpm -q --provides -p ../RPMS/noarch/perl-syntax-0.004-1.fc18.noarch.rpm |sort |uniq -c 1 perl(syntax) = 0.004 1 perl-syntax = 0.004-1.fc18 Binary provides are Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-syntax-0.004-1.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4097368). Ok. Package is in line with Fedora and Perl packaging guidelines. Please consider fixing the `TODO' items before building the package. Resolution: Package APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review