https://bugzilla.redhat.com/show_bug.cgi?id=821229 Parag AN(पराग) <panemade@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|nobody@xxxxxxxxxxxxxxxxx |panemade@xxxxxxxxx Flags| |fedora-review+ --- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> --- Review:- + koji build (f18)-> http://koji.fedoraproject.org/koji/taskinfo?taskID=4097307 + rpmlint on rpms gave fcitx-sunpinyin.src: W: spelling-error %description -l en_US backoff -> back off, back-off, kickoff fcitx-sunpinyin.src: W: spelling-error %description -l en_US bigram -> bi gram, bi-gram, big ram fcitx-sunpinyin.src: W: spelling-error %description -l en_US trigram -> trig ram, trig-ram, centigram fcitx-sunpinyin.src: W: invalid-url Source0: http://fcitx.googlecode.com/files/fcitx-sunpinyin-0.3.6.tar.xz HTTP Error 404: Not Found fcitx-sunpinyin.x86_64: W: spelling-error %description -l en_US backoff -> back off, back-off, kickoff fcitx-sunpinyin.x86_64: W: spelling-error %description -l en_US bigram -> bi gram, bi-gram, big ram fcitx-sunpinyin.x86_64: W: spelling-error %description -l en_US trigram -> trig ram, trig-ram, centigram fcitx-sunpinyin.x86_64: E: incorrect-fsf-address /usr/share/doc/fcitx-sunpinyin-0.3.6/COPYING 2 packages and 0 specfiles checked; 1 errors, 7 warnings. ==> ok to ignore + Source verified with upstream as (sh1sum) 0a248aa1f286b3aed0676391ed26d3b8ddf912c3 ../SOURCES/fcitx-sunpinyin-0.3.6.tar.xz 0a248aa1f286b3aed0676391ed26d3b8ddf912c3 fcitx-sunpinyin-0.3.6.tar.xz Suggestions: 1) Please ass corresponding popd in %build 2) The correct way to handle locale files is remove manually generation of %{name}.lang in spec file and use "%find_lang %{name}" at the end of %install section. See https://fedoraproject.org/wiki/Packaging/Guidelines#Handling_Locale_Files 3) remove Requires: fcitx-data you need to fix fcitx package to only own %{_datadir}/fcitx/inputmethod APPROVED. -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review