[Bug 824052] Review Request: fcitx-m17n - M17n Engine for Fcitx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=824052

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
           Assignee|andrew@xxxxxxxxxxx          |panemade@xxxxxxxxx
              Flags|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> ---
Review:-

+ Koji build used ->http://koji.fedoraproject.org/koji/taskinfo?taskID=4094875

+ rpmlint on rpms gave
fcitx-m17n.src: W: invalid-url Source0:
http://fcitx.googlecode.com/files/fcitx-m17n-0.1.2.tar.xz HTTP Error 404: Not
Found
2 packages and 0 specfiles checked; 0 errors, 1 warnings.

+ Source verified with upstream as (sha1sum)
98ba1d134085e75c92e5303f0d3a1d132fefe8c4  fcitx-m17n-0.1.2.tar.xz
98ba1d134085e75c92e5303f0d3a1d132fefe8c4  ../SOURCES/fcitx-m17n-0.1.2.tar.xz

suggestions:
1) License tag should be LGPLv2+
2) each pushd command should have corresponding popd. please add it in %build

3) Change the fcitx package to own only /usr/share/fcitx/inputmethod/

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]