[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



https://bugzilla.redhat.com/show_bug.cgi?id=801073

--- Comment #10 from Liang Suilong <liangsuilong@xxxxxxxxx> ---
I have updated the latest SPEC file and SRPM file. 

SPEC: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx.spec
SRPM: http://liangsuilong.fedorapeople.org/fcitx/kcm-fcitx-0.3.3-1.fc16.src.rpm
Koji: http://koji.fedoraproject.org/koji/taskinfo?taskID=4096647

(In reply to comment #7)
> Several suggestions:
> 
> 1.  replace
> cat << EOF > %{name}.lang 
> %lang(zh) /usr/share/locale/zh_TW/LC_MESSAGES/kcm_fcitx.mo
> %lang(zh) /usr/share/locale/zh_CN/LC_MESSAGES/kcm_fcitx.mo
> EOF
> 
> with
> %find_lang %{name}
> 

Fixed

> 
> 2.  in %build
> 
> you have
> pushd build
> 
> but no matching
> popd
> 

Fixed

> 
> 3.  (cosmetics, but shorter) in %install, replace
> pushd build
> make install DESTDIR=$RPM_BUILD_ROOT
> popd
> 
> with
> make install  DESTDIR=$RPM_BUILD_ROOT -C build


Fixed

(In reply to comment #9)
> ah, in that case,
> 
> find_lang %{name} --all-name --with-kde
> 
> to be on the safe side. :)

-- 
You are receiving this mail because:
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]