https://bugzilla.redhat.com/show_bug.cgi?id=824083 Ben Rosser <rosser.bjr@xxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rosser.bjr@xxxxxxxxx --- Comment #2 from Ben Rosser <rosser.bjr@xxxxxxxxx> --- As I need sponsorship (and reviews of my own package request), this can't be a formal review. I did look into a few things though: I followed the github link and it downloaded "klange-nyancat-stable-2-g5fe3de9.tar.gz"- not something on the format of "klange-nyancat-5fe3de9.tar.gz". So after downloading I had to do "mv klange-nyancat-stable-2-g5fe3de9.tar.gz klange-nyancat-5fe3de9.tar.gz"- you might want to mention this is necessary in the spec? (Or modify the spec to deal with that?) Other than that, this seems fine.. rpmlint finds a couple of "spelling errors" and the invalid URL in the spec, which are false positives for this package. It does also note the lack of a man page for a binary, but that's it. nyancat.src: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er nyancat.src: W: spelling-error %description -l en_US poptart -> pop tart, pop-tart, polestar nyancat.src: W: invalid-url Source0: klange-nyancat-5fe3de9.tar.gz nyancat.x86_64: W: spelling-error Summary(en_US) renderer -> tenderer, rendered, render er nyancat.x86_64: W: spelling-error %description -l en_US poptart -> pop tart, pop-tart, polestar nyancat.x86_64: W: no-manual-page-for-binary nyancat -- You are receiving this mail because: You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review