[Bug 801073] Review Request: kcm-fcitx - KDE Config Module for Fcitx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Comment # 7 from
Several suggestions:

1.  replace
cat << EOF > %{name}.lang 
%lang(zh) /usr/share/locale/zh_TW/LC_MESSAGES/kcm_fcitx.mo
%lang(zh) /usr/share/locale/zh_CN/LC_MESSAGES/kcm_fcitx.mo
EOF

with
%find_lang %{name}


2.  in %build

you have
pushd build

but no matching
popd


3.  (cosmetics, but shorter) in %install, replace
pushd build
make install DESTDIR=$RPM_BUILD_ROOT
popd

with
make install  DESTDIR=$RPM_BUILD_ROOT -C build


You are receiving this mail because:
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review

[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]