| What | Removed | Added |
|---|---|---|
| Status | NEW | ASSIGNED |
| Flags | fedora-review? | fedora-review+ |
Comment # 1
from Petr Pisar
Source file is original. Ok.
URL and Source0 are usable. Ok.
Summary verified from lib/Task/Kensho/Exceptions.pm. Ok.
License verified from lib/Task/Kensho/Exceptions.pm. Ok.
No XS code, noarch BuildArch is Ok.
Description is Ok.
Although this is dependency only meta package, run-requires are needed to pass
build-time checks. Ok.
TODO: I'm not sure how much helpful is MYMETA.yml file. It contains building
instructions and data available form already installed POD. I recommend not to
install it.
All tests pass. Ok.
$ rpmlint perl-Task-Kensho-Exceptions.spec
../SRPMS/perl-Task-Kensho-Exceptions-0.28-1.fc18.src.rpm
../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm
2 packages and 1 specfiles checked; 0 errors, 0 warnings.
rpmlint is Ok.
$ rpm -q -lv -p
../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm
drwxr-xr-x 2 root root 0 May 22 17:48
/usr/share/doc/perl-Task-Kensho-Exceptions-0.28
-rw-r--r-- 1 root root 3252 Mar 26 2011
/usr/share/doc/perl-Task-Kensho-Exceptions-0.28/Changes
-rw-r--r-- 1 root root 613 May 22 17:48
/usr/share/doc/perl-Task-Kensho-Exceptions-0.28/MYMETA.yml
-rw-r--r-- 1 root root 1485 Jan 20 2011
/usr/share/doc/perl-Task-Kensho-Exceptions-0.28/README
-rw-r--r-- 1 root root 3361 May 22 17:48
/usr/share/man/man3/Task::Kensho::Exceptions.3pm.gz
drwxr-xr-x 2 root root 0 May 22 17:48
/usr/share/perl5/vendor_perl/Task
drwxr-xr-x 2 root root 0 May 22 17:48
/usr/share/perl5/vendor_perl/Task/Kensho
-rw-r--r-- 1 root root 3295 Mar 26 2011
/usr/share/perl5/vendor_perl/Task/Kensho/Exceptions.pm
File permissions and layout are Ok.
$ rpm -q --requires -p
../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm |sort |uniq
-c
1 perl(autodie)
1 perl(:MODULE_COMPAT_5.14.2)
1 perl(strict)
1 perl(TryCatch)
1 perl(Try::Tiny)
1 rpmlib(CompressedFileNames) <= 3.0.4-1
1 rpmlib(FileDigests) <= 4.6.0-1
1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1
1 rpmlib(PayloadIsXz) <= 5.2-1
Binary requires are Ok.
$ rpm -q --provides -p
../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm |sort |uniq
-c
1 perl(Task::Kensho::Exceptions) = 0.28
1 perl-Task-Kensho-Exceptions = 0.28-1.fc18
Binary provides are Ok.
$ resolvedeps rawhide
../RPMS/noarch/perl-Task-Kensho-Exceptions-0.28-1.fc18.noarch.rpm
Binary dependencies resolvable. Ok.
Package builds in F18
(http://koji.fedoraproject.org/koji/taskinfo?taskID=4094843). Ok.
Package is line with Fedora and Perl packaging guidelines.
Please consider fixing the TODO items before building this package.
Resolution: Package APPROVED.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review