Comment # 11
from pcpa
(In reply to comment #10) > I just run fedora-review and this is issues sans those I waived out. Thanks for the review! > Issues: > [!]: MUST Each %files section contains %defattr if rpm < 4.4 > Note: defattr(....) present in %files section. This is OK if packaging > for EPEL5. Otherwise not needed > See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions I will remove it for the next package. > [!]: MUST Package contains a properly installed %{name}.desktop using > desktop- > file-install file if it is a GUI application. > See: http://fedoraproject.org/wiki/Packaging/Guidelines#desktop I will add a call to desktop-file-validate and correct any problems that arise. > [!]: MUST Rpmlint output is silent. > > rpmlint 0ad-debuginfo-r11863-2.fc18.i686.rpm > > 0ad-debuginfo.i686: W: only-non-binary-in-usr-lib > 1 packages and 0 specfiles checked; 0 errors, 1 warnings. > > See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint > [!]: MUST Sources used to build the package match the upstream source, as > provided in the spec URL. > /tmp/818401/0ad-r11863-alpha-unix-build.tar.xz : > MD5SUM this package : f42a2e18515cbcd48b99f0ea3796b3a4 > MD5SUM upstream package : f577f8d3a69146cfdc988a56f3caecd8 > > See: http://fedoraproject.org/wiki/Packaging/SourceURL I just did download it again to ensure it was not replaced by upstream. I think your test may have donwloaded the tar.gz file, did uncompress it, or did download some .html file... $ LC_ALL=C wget http://releases.wildfiregames.com/0ad-r11863-alpha-unix-build.tar.xz --2012-05-22 11:50:53-- http://releases.wildfiregames.com/0ad-r11863-alpha-unix-build.tar.xz Resolving releases.wildfiregames.com (releases.wildfiregames.com)... 92.243.18.55 Connecting to releases.wildfiregames.com (releases.wildfiregames.com)|92.243.18.55|:80... connected. HTTP request sent, awaiting response... 301 Moved Permanently Location: http://sourceforge.net/projects/zero-ad/files/releases/0ad-r11863-alpha-unix-build.tar.xz/download [following] --2012-05-22 11:50:54-- http://sourceforge.net/projects/zero-ad/files/releases/0ad-r11863-alpha-unix-build.tar.xz/download Resolving sourceforge.net (sourceforge.net)... 216.34.181.60 Connecting to sourceforge.net (sourceforge.net)|216.34.181.60|:80... connected. HTTP request sent, awaiting response... 302 Found Location: http://downloads.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz?r=&ts=1337699972&use_mirror=tenet [following] --2012-05-22 11:50:55-- http://downloads.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz?r=&ts=1337699972&use_mirror=tenet Resolving downloads.sourceforge.net (downloads.sourceforge.net)... 216.34.181.59 Connecting to downloads.sourceforge.net (downloads.sourceforge.net)|216.34.181.59|:80... connected. HTTP request sent, awaiting response... 302 Found Location: http://tenet.dl.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz [following] --2012-05-22 11:50:55-- http://tenet.dl.sourceforge.net/project/zero-ad/releases/0ad-r11863-alpha-unix-build.tar.xz Resolving tenet.dl.sourceforge.net (tenet.dl.sourceforge.net)... 155.232.191.245, 2001:4200:fffc::245 Connecting to tenet.dl.sourceforge.net (tenet.dl.sourceforge.net)|155.232.191.245|:80... connected. HTTP request sent, awaiting response... 200 OK Length: 8657204 (8.3M) [application/octet-stream] Saving to: `0ad-r11863-alpha-unix-build.tar.xz' 100%[======================================>] 8,657,204 1.13M/s in 12s 2012-05-22 11:51:09 (720 KB/s) - `0ad-r11863-alpha-unix-build.tar.xz' saved [8657204/8657204] $ md5sum 0ad-r11863-alpha-unix-build.tar.xz f42a2e18515cbcd48b99f0ea3796b3a4 0ad-r11863-alpha-unix-build.tar.xz > [!]: MUST Development (unversioned) .so files in -devel subpackage, if > present. > Note: 0ad-r11863-2.fc18.i686.rpm : /usr/lib/0ad/libAtlasUI.so > 0ad-r11863-2.fc18.i686.rpm : /usr/lib/0ad/libCollada.so > See: http://fedoraproject.org/wiki/Packaging/Guidelines#DevelPackages I can check if reasonable to add a soversion to those libraries. But they are not really meant to be in -devel packages, as no headers are installed, and they are not in %_libdir on purpose.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review