Comment # 3
from Parag AN(पराग)
Review: + koji build -> http://koji.fedoraproject.org/koji/taskinfo?taskID=4091556 + rpmlint on rpms gave kcm-fcitx.x86_64: E: incorrect-fsf-address /usr/share/doc/kcm-fcitx-0.3.3/COPYING kcm-fcitx.x86_64: E: zero-length /usr/share/doc/kcm-fcitx-0.3.3/README 2 packages and 0 specfiles checked; 2 errors, 0 warnings. + Source verified with upstream as (sha1sum) 83a431d51df5cb2fa049e8e59ab5ccc3685adde0 kcm-fcitx-0.3.3.tar.xz 83a431d51df5cb2fa049e8e59ab5ccc3685adde0 ../SOURCES/kcm-fcitx-0.3.3.tar.xz + Package kcm-fcitx-0.3.3-1.fc18.x86_64 => Provides: kcm-fcitx = 0.3.3-1.fc18 kcm-fcitx(x86-64) = 0.3.3-1.fc18 kcm_fcitx.so()(64bit) Requires: libQtCore.so.4()(64bit) libQtDBus.so.4()(64bit) libQtGui.so.4()(64bit) libc.so.6()(64bit) libc.so.6(GLIBC_2.14)(64bit) libc.so.6(GLIBC_2.2.5)(64bit) libc.so.6(GLIBC_2.3.4)(64bit) libc.so.6(GLIBC_2.8)(64bit) libfcitx-config.so.4()(64bit) libfcitx-core.so.0()(64bit) libfcitx-utils.so.0()(64bit) libkdecore.so.5()(64bit) libkdeui.so.5()(64bit) libkio.so.5()(64bit) libknewstuff3.so.4()(64bit) libstdc++.so.6()(64bit) libstdc++.so.6(CXXABI_1.3)(64bit) libstdc++.so.6(GLIBCXX_3.4)(64bit) rtld(GNU_HASH) Suggestions: 1) Good to use commands in spec actually. replace %{__mkdir} -pv build with mkdir -pv build 2) Remove the zero-length files from installation. For this package remove README from %doc 3) I can't see MimeType key written in desktop files. There is no need of writing http://fedoraproject.org/wiki/Packaging:ScriptletSnippets#desktop-database in spec file. Please remove it.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review