Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: unzip https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226516 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ruben@xxxxxxxxxxxxxxxx |varekova@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-04 07:54 EST ------- Review for release 2.2.1: * RPM name is OK * Source unzip552.tar.gz is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * Encoding should be UTF-8 * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * Spec file: some paths are not replaced with RPM macros (wiki: QAChecklist item 7) * Preserve timestamps with cp -p when installing files Notes: * Please consider using {?dist} (fedoraproject.org/wiki/DistTag) I got a warning during building, is this expected? ln: creating hard link `./Makefile' to `unix/Makefile': File exists Rpmlint is not silent: Source RPM: W: unzip summary-ended-with-dot A utility for unpacking zip files. E: unzip tag-not-utf8 %changelog E: unzip non-utf8-spec-file unzip.spec rpmlint of unzip: W: unzip summary-ended-with-dot A utility for unpacking zip files. E: unzip tag-not-utf8 %changelog -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review