Comment # 1
from Miroslav Suchý
rpmlint katello-cli-0.2.36-1.fc18.src.rpm katello-cli.src: W: invalid-url Source0: katello-cli-0.2.36.tar.gz http://fedoraproject.org/wiki/Packaging:SourceURL Please either provide in comment description how to create this tar.gz (git clone, tito build --tgz) or upload tar.gz to some public web. I prefer the later. Since your project is hosted on fedorahosted.org you can do: scp katello-cli-0.2.36.tar.gz fedorahosted.org:katello it will be then available as: https://fedorahosted.org/releases/k/a/katello/%{name}-%{version}.tar.gz rpmlint katello-cli-common-0.2.36-1.fc18.noarch.rpm katello-cli-common.noarch: W: no-documentation 1 packages and 0 specfiles checked; 0 errors, 1 warnings. [!]: MUST Package consistently uses macros (instead of hard-coded directory names). Note: Using both %{buildroot} and $RPM_BUILD_ROOT [!]: MUST Package has no %clean section with rm -rf %{buildroot} (or $RPM_BUILD_ROOT) Note: Clean is needed only if supporting EPEL [!]: MUST Each %files section contains %defattr if rpm < 4.4 Note: defattr(....) present in %files common section. This is OK if packaging for EPEL5. Otherwise not needed I know that you do not plan to support EPEL5, so please remove it. http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions [!]: SHOULD Spec use %global instead of %define. Note: %define base_name katello %define katello_requires python-iniparse python-simplejson python-kerberos m2crypto PyXML See: http://fedoraproject.org/wiki/Packaging:Guidelines#.25global_preferred_over_.25define >%attr(755,root,root) >%attr(644,root,root) This is default - no need to specify it here. >pushd man >popd Why this? This is IMHO noop.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review