Comment # 4
from Michael Scherer
Forgot to add :
- %defattr(-,root,root,-)
is no longer needed either. ( done by default on all supported fedora, and
epel, except epel 5 ).
- Fedora-review complain that :
cp resources/appicon.svg \
${RPM_BUILD_ROOT}%{_datadir}/icons/hicolor/scalable/apps/scantailor.svg
do not preserve timestamp. so using -p is recommended.
https://fedoraproject.org/wiki/Packaging:Guidelines#Timestamps
Otherwise, seems good, let me just finis and try to install and run it to send
the review.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review