| What | Removed | Added |
|---|---|---|
| Status | NEW | ASSIGNED |
| CC | pikachu.2014@gmail.com | |
| Assignee | nobody@fedoraproject.org | pikachu.2014@gmail.com |
Comment # 1
from Mohamed El Morabity
Hello,
I will review your package, since I need it.
Some comments:
- some rpmlint issues (I dropped the non-significative ones):
flyingsaucer-javadoc.noarch: W: file-not-utf8
/usr/share/doc/flyingsaucer-javadoc-R8/LICENSE-W3C-TEST
flyingsaucer-demos.noarch: W: file-not-utf8
/usr/share/doc/flyingsaucer-demos-R8/LICENSE-W3C-TEST
>> See
https://fedoraproject.org/wiki/PackageMaintainers/Packaging_Tricks#Convert_encoding_to_UTF-8
flyingsaucer-demos.noarch: W: summary-not-capitalized C flyingsaucer demos
flyingsaucer-demos.noarch: W: class-path-in-manifest
/usr/share/java/flyingsaucer/docbook.jar
flyingsaucer-demos.noarch: W: class-path-in-manifest
/usr/share/java/flyingsaucer/aboutbox.jar
flyingsaucer-demos.noarch: W: class-path-in-manifest
/usr/share/java/flyingsaucer/svg.jar
flyingsaucer-demos.noarch: W: class-path-in-manifest
/usr/share/java/flyingsaucer/browser.jar
>> See https://fedoraproject.org/wiki/Packaging:Java#class-path-in-manifest
- xml-commons-apis is already required by ant, you could drop it from the
BuildRequires.
- The patches are OK for me. But you don't need to modify
etc/build/properties.xml (see flyingsaucer-R8-build.patch) to detect itext,
svgsalamander and xml-commons-apis if you put them in the CLASSPATH before
building:
%build
export CLASSPATH=$(build-classpath itext xml-commons-apis svgsalamander)
ant jar docs
- I don't think « R8 » is a good version tag. Setting it simply to « 8 » may be
enough (« R » is probably for « release »).
- The Provides tag on xhtmlrenderer is an excellent idea, as well as providing
the link xhtmlrenderer.jar. You should anyway put it in
%{buildroot}%{_javadocdir}/%{name}, with the other JARs, to comply with the
guidelines:
https://fedoraproject.org/wiki/Packaging:Java#Installation_directory
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review