| What | Removed | Added |
|---|---|---|
| CC | rc040203@freenet.de |
Comment # 4
from Ralf Corsepius
(In reply to comment #2) > (In reply to comment #1) > > > > FIX: Build-require `perl(inc::Module::Install)' (Makefile.PL:3) instead of > > `perl(ExtUtils::MakeMaker)'. > > > > TODO: Consider removing bundled Perl modules under inc/ and build-requiring > > appropriate modules like Module::Install::AuthorTests. Otherwise you need > > explicitly build-require all dependencies of inc/* code. > > > > FIX: Build-require modules used by code under inc/ (ExtUtils::Manifest, > > YAML::Tiny, etc.). I really recommend unbundling inc/*. > > Oh! This is new. IMO, bundled modules in inc are harmless as long as they do not contain modules which later on are being used as run time deps. > I'm not convinced that avoiding bundled Module::Install is > the way to go here. IMO, Module::Install are just "build-/install instruction file fragments" and therefore are OK to be used and to be bundled.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review