Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: wget https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226538 ruben@xxxxxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|ruben@xxxxxxxxxxxxxxxx |karsten@xxxxxxxxxx CC| |ruben@xxxxxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From ruben@xxxxxxxxxxxxxxxx 2007-02-04 07:19 EST ------- Hi Karsten, Review for release 12: * RPM name is OK * Source wget-1.10.2.tar.gz is the same as upstream * Source wget-1.11-de.po is the same as upstream * This is the latest version * Builds fine in mock * File list looks OK * Config files of wget looks OK Needs work: * BuildRoot should be %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) (wiki: PackagingGuidelines#BuildRoot) * BuildRequires: perl should not be included (wiki: PackagingGuidelines#Exceptions) * Missing SMP flags. If it doesn't build with it, please add a comment (wiki: PackagingGuidelines#parallelmake) * The %makeinstall macro should not be used (wiki: PackagingGuidelines#MakeInstall) * The package should contain the text of the license (wiki: Packaging/ReviewGuidelines) COPYING is included in the source, just add it to %doc Notes: * Use Requires(post) and Requires(preun) instead of Prereq * Honour %{optflags} when building * Preserve timestamps when installing Rpmlint is not silent: Source RPM: W: wget summary-ended-with-dot A utility for retrieving files using the HTTP or FTP protocols. W: wget unversioned-explicit-provides webclient W: wget prereq-use /sbin/install-info W: wget macro-in-%changelog xx W: wget mixed-use-of-spaces-and-tabs (spaces: line 65, tab: line 48) rpmlint of wget: W: wget summary-ended-with-dot A utility for retrieving files using the HTTP or FTP protocols. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review