Comment # 13
from Matthias Runge
Michael, thank you for your review. You're right, pygments is required during runtime, not at build time. Also I corrected the usage of buildroot/RPM_BUILD_ROOT updated SPEC: SRPM: http://www.matthias-runge.de/fedora/python-django-dpaste-0.2.4-9.fc17.src.rpm [mrunge@mrungexp SPECS]$ rpmlint /home/mrunge/rpmbuild/SRPMS/python-django-dpaste-0.2.4-9.fc17.src.rpm /home/mrunge/rpmbuild/RPMS/noarch/python-django-dpaste-0.2.4-9.fc17.noarch.rpm ./python-django-dpaste.spec 2 packages and 1 specfiles checked; 0 errors, 0 warnings. @@ -4,7 +4,7 @@ Summary: Dpaste is a code paste-bin application using Django Name: python-django-dpaste Version: 0.2.4 -Release: 8%{?dist} +Release: 9%{?dist} License: BSD with advertising Group: Development/Libraries URL: https://github.com/bartTC/django-paste/ @@ -13,7 +13,7 @@ BuildRequires: python2-devel BuildRequires: python-setuptools Requires: python-django-mptt -BuildRequires: python-pygments +Requires: python-pygments Provides: %{pkgname} = %{version}-%{release} Obsoletes: %{pkgname} < %{obs_ver} @@ -46,7 +46,7 @@ %install %{__python} setup.py install -O1 --skip-build --root="%{buildroot}" --prefix="%{_prefix}" #Language files; not under /usr/share, need to be handled manually -(cd $RPM_BUILD_ROOT && find . -name 'django*.[mp]o') | +(cd %{buildroot} && find . -name 'django*.[mp]o') | %{__sed} -e 's|^.||' | %{__sed} -e \ 's:\(.*/locale/\)\([^/_]\+\)\(.*\.[mp]o$\):%lang(\2) \1\2\3:' \ >> django.lang @@ -65,6 +65,10 @@ %dir %{python_sitelib}/dpaste/locale %changelog +* Mon May 21 2012 Matthias Runge <mrunge@matthias-runge.de> - 0.2.4-9 +- use buildroot instead of RPM_BUILD_ROOT +- corrected requires/buildrequires python-pygments + * Wed May 02 2012 Matthias Runge <mrunge@matthias-runge.de> - 0.2.4-8 - added locale, and subdirs to files-list
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review