| What | Removed | Added |
|---|---|---|
| CC | misc@zarb.org |
Comment # 1
from Michael Scherer
A few notes :
- BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u}
-n)
no longer needed since some time, so it should be removed
https://fedoraproject.org/wiki/Packaging:Guidelines#BuildRoot_tag
- that's the same for
rm -rf $RPM_BUILD_ROOT
in %install and the %clean.
As that's always the same but, now rpm does it by default.
- I think that the license tag should reflect the diversity of license on the
icons. ( ie, some are LGPL, some are GPLv2+, etc ).
https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Multiple_Licensing_Scenarios
- %{__cp} and %{__mv} are not needed, using mv and cp is recommended.
https://fedoraproject.org/wiki/Packaging:Guidelines#Macros
Except that, the package seems good to go, let me start the review
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review