| What | Removed | Added |
|---|---|---|
| CC | misc@zarb.org |
Comment # 5
from Michael Scherer
A few comment - I think the spec layout is rather difficult. While I know everybody has specific preference, I think it would be better to group various %post/%pre script together ( as I missed the one creating oneadmin ) - patches should be commented https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment - is it required to have mysql server on the same computer ? If not, I think the requires could be relaxed. - %setup -q -n opennebula-3.2.1 You should reuse %version, so this is easier to upgrade later - why is the whole .ssh populated in %post, would it better to do it like any other file, with rpm ? ( at least the .ssh/config ), and using %ghost so rpm can manage and check the permission of all file ? - apg is used in a %post script, but the requires is missing ( Requires(post): ) - why do the documentation requires the main packages ? - why do sunstone requires the main package ? According to http://opennebula.org/documentation:archives:rel2.2:sunstone , they can be separated, and I would surely see good reason to deploy them on 2 differents server, for security reason. - From a quick check in open nebula doc, it is not clear why openssh server should be installed on the main hypervisor, could you explain why it is required ? - a oneadmin user is needed on the frontend, but also on the host. So I would suggest to create a package to be used on host that would create the user.
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review