| What | Removed | Added |
|---|---|---|
| CC | misc@zarb.org |
Comment # 3
from Michael Scherer
Hi, I am quickly looking at the spec, here is a few comments : - patch should be annoted, ie, do they come from upstream, if not, have they been sent, and how ( mail, link to bug, etc ) https://fedoraproject.org/wiki/Packaging:Guidelines#All_patches_should_have_an_upstream_bug_link_or_comment - the devel subpackage need to have the license in %doc, as it can be installed without the main package https://fedoraproject.org/wiki/Packaging:LicensingGuidelines#Subpackage_Licensing - not sure that the -devel should requires "automake libtool autoconf". AFAIK, people can build against a library without using autotools, no ? - why do the -devel requires gcc-c++ ? isn't the .so usable without it ? ( there is no .h with it, so I could use it without gcc , no ? ) - same goes for the .la, they should not be packaged (AFAIK) https://fedoraproject.org/wiki/Packaging:Guidelines#Packaging_Static_Libraries - there is a global variable not used : %global namedversion %{version}%{?namedreltag} so maybe it is not needed and should be removed ?
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review