Comment # 6
from Remi Collet
About Requires: Yes, using the wirtual provides is better, (it's the reallity), and PHP sub-package spliting could change in the future (and have changed in the past) The only problem is that most virtual are not versionned (could be consider as a bug in PHP, but not so simple), so you can requires php-mbstring >= 5.3.2 but you can only requires php-posix (without version). Be carefull with php-xml (xml extension is provided by php-common, this package provides other extensions: dom, wddx, xmlreader, xmlwriter and xsl) About License: Yes, "sed" is ok. We don't have to wait for a new upstream release. It would be very suprising that they refuse. (except for a very good reason, which must be documented, and then, apply to the spec) Good pratice about such patch/change is to add a comment in the spec with a link to upstream answer (ML archive, commit, ...) About script: If a script use the php shebang, I think it will be autodetect by rpmbuild and added to the package dependencies (so using "env" is a bad solution) => to be checked (I can't because AFK)
You are receiving this mail because:
- You are on the CC list for the bug.
_______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review