[Bug 823096] Review Request: nvidia-texture-tools - Collection of image processing and texture manipulation tools

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=823096

--- Comment #3 from pcpa <paulo.cesar.pereira.de.andrade@xxxxxxxxx> 2012-05-19 00:51:00 EDT ---
Thanks for noticing it.

A grep -ri s3tc shows only references to it in
src/nvtt/squish/texture_compression_s3tc.txt

otherwise, the only other reference is in
src/nvtt/CompressDXT.cpp

#if defined(HAVE_S3QUANT)
#include "s3tc/s3_quant.h"
#endif

and HAVE_S3QUANT is not defined.

and the actual code, in the same file is also
inside an inclusion guard:

#if defined(HAVE_S3QUANT)
void nv::s3CompressDXT1(const Image * image, const nvtt::OutputOptions::Private
& outputOptions)
{
...
}
#endif

Actually, that same source also has another

#if defined(HAVE_ATITC)
#include "atitc/ATI_Compress.h"
#endif

and a void nv::atiCompressDXT1 function compiled
if HAVE_ATITC is defined.

So, from my understanding, there is no binary code
using it, neither exposing interfaces to it.

But there is source code that is not compiled,
that may interface those if the devel/runtime is
detected at build time.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]