Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: ncpfs https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=226186 ------- Additional Comments From tibbs@xxxxxxxxxxx 2007-02-04 00:35 EST ------- This should be fun. First, the rpmlint issues: W: ncpfs no-url-tag Is there actually an upstream for this? It's probably best to at least add URL: http://ftp.cvut.cz/ncpfs/ W: ncpfs devel-file-in-non-devel-package /usr/lib/libncp.so W: ncpfs devel-file-in-non-devel-package /usr/include/ncp/obsolete/o_ndslib.h And many more .h files. These should all be placed into a separate -devel subpackage. E: ncpfs setuid-binary /usr/bin/ncplogin root 04755 E: ncpfs non-standard-executable-perm /usr/bin/ncplogin 04755 A couple like these. I suppose these are necessary, but has anyone looked at the security issues? Just adding URL: and making the -devel packages would take care of all of the real rpmlint issues. More review coming tomorrow after sleep. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review