Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=817391 --- Comment #32 from Adrian Alves <aalves@xxxxxxxxx> 2012-05-17 18:44:13 EDT --- (In reply to comment #31) > (In reply to comment #30) > > (In reply to comment #27) > > > (In reply to comment #26) > > > > other thing that I just found now is /etc/sudoers.d/999-jupiter > > > > is not in file list . > > > > shouldn't add 999-jupiter at post, should be in install for when remove package > > > > also remove /etc/sudoers.d/999-jupiter . > > > > > > > > about %build > > > > > > > > normally in build we have: > > > > > > > > ./configure > > > > make > > > > > > Sergio I dont have anything to build thats why I removed %build tag thats why i > > > didnt use it but I added because u ask but i think %build is not necessary in > > > this case > > > > Put a empty %build tag should be better, more readable and no errors in > > fedora-review , > There was a time rpm mandatorily required a *.spec to carry %prep, %build and > %install sections to work properly. > > I don't know if this still applies, but would suggest to add an empty %build > section. > > > sed -i "s/^Defaults[ \t]*requiretty/#Defaults requiretty/g" /etc/sudoers > > why you need change sudoers ? > I don't understand why this step is required and what it is supposed to do. > > > for i in $(awk -F: '$6 ~ /\/home/ && $3 >= 500 {print $1}' /etc/passwd); > > do > > echo -n $i" " > > usermod -G jupiter -a $i 2>/dev/null || true > > done > If I understand correctly, you are trying to add all users with uid >= 500 in > /etc/passwd to the jupiter group. > > Apart from the fact that "plain searching /etc/passwd" for uid lacks generality > to make this work reliable (/etc/passwd is not the only way to host accounts), > and that using a hard-coded uid of 500 doesn't make much sense (I guess you are > presuming "ordinary users have a uid of >= 500" - This assumption is invalid), > I don't understand the sense of this. > > IMO, adding existing non-reserved uids to groups should remain an admin's task > and require manual interaction, in general. I added all your suggestions: Spec URL: http://alvesadrian.fedorapeople.org/jupiter.spec SRPM URL: http://alvesadrian.fedorapeople.org/jupiter-0.1.2-7.fc16.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review