Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: gpart https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225853 ------- Additional Comments From dcantrell@xxxxxxxxxx 2007-02-03 22:07 EST ------- (In reply to comment #1) > Need to be Fixed: > * rpmlint error: > W: gpart-debuginfo no-url-tag > Need to add URL: http://www.stud.uni-hannover.de/user/76201/gpart/ Done. > Minor: > * Doesn't use preferred buildroot: > %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) Done. > * Drop the '.' from the summary to quite rpmlint. Done. > * Should use path macro. %{_bindir}/gpart I changed it to use %makeinstall instead. Also noticed the debuginfo package didn't actually contain anything. The src/Makefile was installing the gpart binary stripped, so there was nothing to pack in to debuginfo form. Fixed that. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review