[Bug 817391] Review Request: jupiter - Jupiter Hardware Control System for Computers

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=817391

--- Comment #30 from Sergio Monteiro Basto <sergio@xxxxxxxxxx> 2012-05-16 22:50:21 EDT ---
(In reply to comment #27)
> (In reply to comment #26)
> > other thing that I just found now is /etc/sudoers.d/999-jupiter 
> > is not in file list . 
> > shouldn't add 999-jupiter at post, should be in install for when remove package
> > also remove  /etc/sudoers.d/999-jupiter  .
> > 
> > about %build 
> > 
> > normally in build we have:  
> > 
> > ./configure
> > make
> 
> Sergio I dont have anything to build thats why I removed %build tag thats why i
> didnt use it but I added because u ask but i think %build is not necessary in
> this case

Put a empty %build tag should be better, more readable and no errors in
fedora-review , 

> probably if I remove the %post tag and make everything that post does in the
> %install section?

yeah you should move many things to install , I see that now. 

%post does nothing when it make the package and just do things (as root) when
we install package. 

so add user must be on %post, 

chmod and mkdir should be in %install and %file , don't need to verify is
existence. 

sed -i "s/^Defaults[ \t]*requiretty/#Defaults    requiretty/g" /etc/sudoers
why you need change sudoers ? 

for i in $(awk -F: '$6 ~ /\/home/ && $3 >= 500 {print $1}' /etc/passwd);
 do
   echo -n $i" "
   usermod -G jupiter -a $i 2>/dev/null || true
 done

in %postun (post uninstall) you must revert all of this, remove user etc. 
that the great of rpm. 

Note: I just land here, and I'm try to help you , but not in my power sponsor
you. I just like the jupiter thing and try to try it.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]