Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=730764 --- Comment #7 from Domingo Becker <domingobecker@xxxxxxxxx> 2012-05-16 18:08:31 EDT --- (In reply to comment #6) > > wxpdfdoc.spec:49: W: rpm-buildroot-usage %build make > > -C build prefix=$RPM_BUILD_ROOT%{_prefix} all -f GNUmakefile > > $RPM_BUILD_ROOT should not be touched during %build or %prep stage, > > as it may break short circuit builds. > > Actually, there is a bigger risk than that. This buildroot path may enter the > built files as part of any path that is derived from the "prefix" value. It's a > common packaging pitfall. So, avoid using $RPM_BUILD_ROOT or %buildroot prior > to %install. > Fixed. > > > Group: Development/Libraries > > Base libs typically enter group "System Environment/Libraries" instead. > Fixed. > > > gcc-c++ > > This is covered by: > https://fedoraproject.org/wiki/Packaging:Guidelines#Exceptions_2 > > Hard-requiring gcc-c++ also makes it less simple to rebuild within a replaced > minimum build environment. > Understood and fixed. > > > %package devel > > Requires: wxpdfdoc > > https://fedoraproject.org/wiki/Packaging:Guidelines#Requiring_Base_Package > Fixed. > > > %files > > %{_libdir}/libwxcode_gtk2_pdfdoc* > > I'd like to see a test-build of the package to judge about whether this %files > section is correct. > http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc-0.9.2.1-2.fc14.i686.rpm http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc-devel-0.9.2.1-2.fc14.i686.rpm The dynamic library went to the same /usr/lib directory as wxGTK package. > > > %files devel > > %{_includedir}/wx/pdf* > > %{_prefix}/src/pdf* > > The -devel package would need to depend on wxGTK-devel for proper dir > ownership. And the usage of /usr/src needs a look at the test-build, too. Files in /usr/src and /usr/include/wx have been moved to /usr/include/wx-2.8/wx, which is the same for wxGTK-devel header files. Fixed dependency on wxGTK-devel too. The package has been updated to the latest release. Spec URL: http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc.spec SRPM URL: http://beckerde.fedorapeople.org/wxpdfdoc/wxpdfdoc-0.9.2.1-2.fc14.src.rpm -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review