Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819192 --- Comment #3 from Kevin Fenzi <kevin@xxxxxxxxx> 2012-05-16 13:51:33 EDT --- OK - Package meets naming and packaging guidelines OK - Spec file matches base package name. OK - Spec has consistant macro usage. OK - Meets Packaging Guidelines. OK - License (GPLv2+) See below - License field in spec matches OK - License file included in package OK - Spec in American English OK - Spec is legible. OK - Sources match upstream md5sum: c5b86cbc1c54ee7c1d2e95a4502fed8e xfce4-embed-plugin-1.0.0.tar.bz2 c5b86cbc1c54ee7c1d2e95a4502fed8e xfce4-embed-plugin-1.0.0.tar.bz2.orig OK - BuildRequires correct OK - Spec handles locales/find_lang OK - Package has %defattr and permissions on files is good. OK - Package has a correct %clean section. OK - Package has correct buildroot OK - Package is code or permissible content. OK - Packages %doc files don't affect runtime. OK - Package has rm -rf RPM_BUILD_ROOT at top of %install OK - Package compiles and builds on at least one arch. OK - Package has no duplicate files in %files. OK - Package doesn't own any directories other packages own. OK - Package owns all the directories it creates. OK - Package obey's FHS standard (except for 2 exceptions) See below - No rpmlint output. OK - final provides and requires are sane. SHOULD Items: OK - Should build in mock. OK - Should build on all supported archs OK - Should function as described. OK - Should have sane scriptlets. OK - Should have dist tag OK - Should package latest version OK - Should not use file requires outside of /etc, /bin, /sbin, /usr/bin, or /usr/sbin Issues: 1. Why is this release 0.1? It looks like the final 1.0.0? 2. License tag should be "GPLv2+" 3. Your Source0 is: Source0: http://archive.xfce.org/src/panel-plugins/%{name}/%{minor_version}/%{name}-%{version}.tar.bz2 but you don't define %{minor_version} anywhere. ;) Add a '%global minor_version 1.0' to the top? 4. rpmlint says: Can be ignored: xfce4-embed-plugin.i686: W: spelling-error Summary(en_US) Xfce -> Face xfce4-embed-plugin.i686: W: spelling-error %description -l en_US resized -> resided, re sized, re-sized xfce4-embed-plugin.src: W: spelling-error Summary(en_US) Xfce -> Face xfce4-embed-plugin.src: W: spelling-error %description -l en_US resized -> resided, re sized, re-sized Might ask upstream to update their COPYING file sometime: xfce4-embed-plugin.i686: E: incorrect-fsf-address /usr/share/doc/xfce4-embed-plugin-1.0.0/COPYING xfce4-embed-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/xfce4-embed-plugin-1.0.0/panel-plugin/ewmh.h xfce4-embed-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/xfce4-embed-plugin-1.0.0/panel-plugin/ewmh.c xfce4-embed-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/xfce4-embed-plugin-1.0.0/panel-plugin/embed.c xfce4-embed-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/xfce4-embed-plugin-1.0.0/panel-plugin/embed.h xfce4-embed-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/xfce4-embed-plugin-1.0.0/panel-plugin/embed-dialogs.c xfce4-embed-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/xfce4-embed-plugin-1.0.0/panel-plugin/embed-dialogs.h Should be fixed when minor_version exists: xfce4-embed-plugin.src: W: invalid-url Source0: http://archive.xfce.org/src/panel-plugins/xfce4-embed-plugin/%{minor_version}/xfce4-embed-plugin-1.0.0.tar.bz2 HTTP Error 400: Bad Request 3 packages and 0 specfiles checked; 7 errors, 5 warnings. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review