Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=821838 --- Comment #5 from Simone Caronni <negativo17@xxxxxxxxx> 2012-05-15 13:01:08 EDT --- EPEL 5: Looking at the spec file I assume that the package will not be built for EPEL 5. [!]: MUST If (and only if) the source package includes the text of the license(s) in its own file, then that file, containing the text of the license(s) for the package is included in %doc. The archive includes the "COPYING" file but that's not included in the %doc section. [!]: MUST Rpmlint output is silent. gitolite3.noarch: W: spelling-error %description -l en_US userids -> use rids, use-rids, user ids gitolite3.noarch: W: spelling-error %description -l en_US ssh's -> ash's, sash's gitolite3.noarch: W: spelling-error %description -l en_US pubkey -> pub key, pub-key, puberty gitolite3.noarch: W: spelling-error %description -l en_US gitosis -> mitosis, halitosis gitolite3.src: W: spelling-error %description -l en_US Gitolite -> Impolite gitolite3.src: W: spelling-error %description -l en_US userids -> use rids, use-rids, user ids gitolite3.src: W: spelling-error %description -l en_US ssh's -> ash's, sash's gitolite3.src: W: spelling-error %description -l en_US pubkey -> pub key, pub-key, puberty gitolite3.src: W: spelling-error %description -l en_US gitosis -> mitosis, halitosis gitolite3.src: W: spelling-error %description -l en_US perl -> Perl, peel, perk Dictionary errors, can be ignored (halitosis?). gitolite3.noarch: E: script-without-shebang /usr/share/perl5/vendor_perl/Gitolite/Triggers/CpuTime.pm gitolite3.noarch: E: script-without-shebang /usr/share/gitolite3/lib/Gitolite/Triggers/CpuTime.pm No interpreter for perl modules, can be ignored. gitolite3.noarch: E: script-without-shebang /usr/share/gitolite3/syntactic-sugar/continuation-lines gitolite3.noarch: E: script-without-shebang /usr/share/gitolite3/syntactic-sugar/keysubdirs-as-groups Do these need an interpreter at the top? gitolite3.noarch: W: non-standard-uid /var/lib/gitolite3/.ssh/authorized_keys gitolite3 gitolite3.noarch: W: non-standard-gid /var/lib/gitolite3/.ssh/authorized_keys gitolite3 gitolite3.noarch: W: non-standard-uid /var/lib/gitolite3 gitolite3 gitolite3.noarch: W: non-standard-gid /var/lib/gitolite3 gitolite3 gitolite3.noarch: E: non-standard-dir-perm /var/lib/gitolite3 0750L gitolite3.noarch: W: non-standard-uid /var/lib/gitolite3/.ssh gitolite3 gitolite3.noarch: W: non-standard-gid /var/lib/gitolite3/.ssh gitolite3 gitolite3.noarch: W: hidden-file-or-dir /var/lib/gitolite3/.ssh I suppose these can be ignored as per the package structure and the way the user is confined. gitolite3.noarch: E: non-standard-dir-perm /var/lib/gitolite3/.ssh 0750L gitolite3.noarch: W: hidden-file-or-dir /var/lib/gitolite3/.ssh gitolite3.noarch: E: non-readable /var/lib/gitolite3/.ssh/authorized_keys 0640L gitolite3.noarch: E: zero-length /var/lib/gitolite3/.ssh/authorized_keys Maybe (I'm not sure) this line can be removed from the spec file: %attr(750,%{name},%{name}) %{gitolite_homedir}/.ssh and a %ghost could be added to the authorized_keys file. Or another option can be like pcpa stated in Comment #3 gitolite3.noarch: W: no-manual-page-for-binary gitolite Can be ignored. gitolite3.noarch: E: non-executable-script /usr/share/gitolite3/VREF/MERGE-CHECK 0644L /usr/bin/perl I think this is wrong, all the other scripts in /usr/share/gitolite3/VREF/ are executable. gitolite3.src: W: invalid-url Source0: sitaramc-gitolite-v3.01-0-g88b4c86-nodocs.tar.gz Missing script to generate tarball in the SRPM. 2 packages and 0 specfiles checked; 9 errors, 20 warnings. [!]: MUST Sources used to build the package match the upstream source, as provided in the spec URL. Package has no sources or they are generated by developer Script to generate the sources tarball from the git repository with the declared components excluded is missing: http://fedoraproject.org/wiki/Packaging:SourceURL#When_Upstream_uses_Prohibited_Code -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review