Please do not reply directly to this email. All additional comments should be made in the comments box of this bug report. Summary: Merge Review: createrepo https://bugzilla.redhat.com/bugzilla/show_bug.cgi?id=225661 roozbeh@xxxxxxxxxxxxx changed: What |Removed |Added ---------------------------------------------------------------------------- AssignedTo|roozbeh@xxxxxxxxxxxxx |pnasrat@xxxxxxxxxx CC| |roozbeh@xxxxxxxxxxxxx Flag|fedora-review? |fedora-review- ------- Additional Comments From roozbeh@xxxxxxxxxxxxx 2007-02-03 20:24 EST ------- GOOD ==== MUST: naming is fine MUST: spec filename matches %{name} MUST: free software MUST: License matches actual license (GPL) MUST: neither source package nor RPM contain the license file MUST: source matches upstream (md5sum checked) MUST: compiled and built as noarch MUST: no ExcludeArch MUST: no real build dep, instead of the minimum gang MUST: no locales MUST: not a lib, so no ldconfig MUST: not relocatable MUST: owns its dirs MUST: no dup files MUST: clean section fine MUST: macro use consistent MUST: no large docs MUST: docs don't affect runtime MUST: no header, libs or devel package MUST: not GUI MUST: doesn't own others' dirs BAD / COULD BE BETTER ===================== MUST: rpmlint output * SRPM: W: createrepo no-%build-section rpmlint suggests you add an empty %build section anyway. * RPM: E: createrepo explicit-lib-dependency libxml2-python I think this is a false hit. MUST: US English * The description field should have a period at the end. MUST: spec file legiblity * The scriptlet check for RPM_BUILD_ROOT for not being equal to / is unnecessary and obsfucating. The value of that variable may as well be equal to /lib or /etc and destroy a system. Never run rpmbuild as root! MUST: file permissions * %defattr should be changed to %defattr(-, root, root, -), i.e., extra "-" at the end. MUST: Packaging Guidelines * The dependency on rpm should be changed to ">= 4.1.1", as current rpm in Rawhide doesn't have any epoch. * Source tag should be change to include full URL: http://linux.duke.edu/projects/metadata/generate/%{name}-%{version}.tar.gz * BuildRoot should be changed to: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n) * %makeinstall should be replaced with: make DESTDIR=$RPM_BUILD_ROOT install * Instead of: %dir %{_datadir}/%{name} %{_datadir}/%{name}/* you can simply do: %{_datadir}/%{name} SHOULD: Upstream should be pinged to add license file (GPL) to package Other: * 'sources' and '.cvsignore' files (in CVS) contain lots of old versions. Remove older versions. -- Configure bugmail: https://bugzilla.redhat.com/bugzilla/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are the QA contact for the bug, or are watching the QA contact. _______________________________________________ Fedora-package-review mailing list Fedora-package-review@xxxxxxxxxx http://www.redhat.com/mailman/listinfo/fedora-package-review