Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=820488 --- Comment #2 from Jon Ciesla <limburgher@xxxxxxxxx> 2012-05-15 12:30:51 EDT --- Good: - rpmlint checks return: mod_auth_xradius-debuginfo.x86_64: W: spelling-error Summary(en_US) auth -> auto, Ruth, author The value of this tag appears to be misspelled. Please double-check. mod_auth_xradius-debuginfo.x86_64: W: spelling-error Summary(en_US) xradius -> radius, x radius, radium The value of this tag appears to be misspelled. Please double-check. mod_auth_xradius-debuginfo.x86_64: W: spelling-error %description -l en_US auth -> auto, Ruth, author The value of this tag appears to be misspelled. Please double-check. mod_auth_xradius-debuginfo.x86_64: W: spelling-error %description -l en_US xradius -> radius, x radius, radium The value of this tag appears to be misspelled. Please double-check. 2 packages and 0 specfiles checked; 0 errors, 4 warnings. Ignore, otherwise clean. - package meets naming guidelines - package meets packaging guidelines X license ( ASL 2.0 ) OK, text in %doc, matches source except for md5. - spec file legible, in am. english - source matches upstream - package compiles on devel (x86) - no missing BR - no unnecessary BR - no locales - not relocatable - owns all directories that it creates - no duplicate files - permissions ok - %clean ok - macro use consistent - code, not content - no need for -docs - nothing in %doc affects runtime - no need for .desktop file In auth_xradius.conf, should line 16 possibly be limited to just localhost by default? Maybe with what's there present, but commented out? Bundles md5, which is OK, but needs to Provide bundled(md5-$IMPLEMENTATION). Not sure what implementation we have here, might be a new one for the list. Bundles libradius. Where's it from? Is there an upstream we can package? -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review