[Bug 821247] Review Request: fcitx-table-other - Oher tables for Fcitx

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=821247

Parag AN(पराग) <panemade@xxxxxxxxx> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
                 CC|                            |panemade@xxxxxxxxx
         AssignedTo|nobody@xxxxxxxxxxxxxxxxx    |panemade@xxxxxxxxx
               Flag|                            |fedora-review?

--- Comment #1 from Parag AN(पराग) <panemade@xxxxxxxxx> 2012-05-15 05:14:09 EDT ---
Review:-
+ koji scratch build for f18 ->
http://koji.fedoraproject.org/koji/taskinfo?taskID=4074057

+ rpmlint on rpms gave
fcitx-table-other.src: W: spelling-error %description -l en_US ibus -> ibis,
bus, i bus
fcitx-table-other.src: W: strange-permission fcitx-table-other.spec 0775L
fcitx-table-other.src: W: invalid-url Source0:
http://fcitx.googlecode.com/files/fcitx-table-other-0.1.0.tar.xz HTTP Error
404: Not Found
fcitx-table-other.noarch: W: spelling-error %description -l en_US ibus -> ibis,
bus, i bus
2 packages and 0 specfiles checked; 0 errors, 4 warnings.


+ Source verified with upstream as (sha1sum)
e3deab3d66f87321c1b1e71762e5a529eb2b324b 
../SOURCES/fcitx-table-other-0.1.0.tar.xz
e3deab3d66f87321c1b1e71762e5a529eb2b324b  fcitx-table-other-0.1.0.tar.xz


Suggestions:-
1) spec file got strange permissions. use "chmod 644 fcitx-table-other.spec"
and then build srpm and use it to import in Fedora.

2) License is not clear. COPYING says GPLv3+ whereas compose and emoji tables
are LGPLv2+ and LGPL
and spec then says GPLv2+

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]