[Bug 722713] Review Request: pyace - Optimal route search in a complete graph

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Please do not reply directly to this email. All additional
comments should be made in the comments box of this bug.


https://bugzilla.redhat.com/show_bug.cgi?id=722713

--- Comment #21 from Volker Fröhlich <volker27@xxxxxx> 2012-05-14 17:51:21 EDT ---
I'm afraid you can't install %{python_sitelib}/operations and
%{python_sitelib}/optimization. This is very generic. Install your package in
one sub-directoy, for instance  %{python_sitelib}/%{name}. You can use that in
the files section than, which simplifies it a lot.

There are a couple of typos/mistakes in README and the manpages, for instance:

"pyACE is a program that resolve complete" -- That should be "resolves", I
guess.
"See the examples or visit the website for know how write the input files."

"the Free Software Foundation, either version 2+ of the License, or
(at your option) any later version." -- That doesn't make sense. That should be
"either version 2 of the License ..."

"You should have received a copy of the GNU General Public License
along with ACE.  If not, see <http://www.gnu.org/licenses/>." -- You don't ship
a copy. Please add one.

The changelog of the spec file is intended for changes in packaging. Don't use
it to describe changes in your software.

Why are you running find_lang twice?

The description should be more detailled than the summary, see:
http://fedoraproject.org/wiki/Packaging:Guidelines#Summary_and_description

I'd put an asterisk for the Python version number in
%{python_sitelib}/%{name}-%{version}-py2.7.egg-info.

Please ship the examples by using the doc macro.

-- 
Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are on the CC list for the bug.
_______________________________________________
package-review mailing list
package-review@xxxxxxxxxxxxxxxxxxxxxxx
https://admin.fedoraproject.org/mailman/listinfo/package-review



[Index of Archives]     [Fedora Legacy]     [Fedora Desktop]     [Fedora SELinux]     [Yosemite News]     [KDE Users]     [Fedora Tools]