Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=812583 Petr Pisar <ppisar@xxxxxxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Flag|fedora-review? |fedora-review+ --- Comment #12 from Petr Pisar <ppisar@xxxxxxxxxx> 2012-05-14 05:31:40 EDT --- Spec file changes: --- perl-FusionInventory-Agent-Task-NetInventory.spec.old 2012-05-14 09:24:17.161998991 +0200 +++ perl-FusionInventory-Agent-Task-NetInventory.spec 2012-05-14 11:20:58.076994420 +0200 @@ -1,6 +1,6 @@ Name: perl-FusionInventory-Agent-Task-NetInventory Version: 2.1 -Release: 3%{?dist} +Release: 4%{?dist} Summary: Remote inventory support for FusionInventory Agent License: GPLv2+ Group: Development/Libraries @@ -20,10 +20,12 @@ BuildRequires: perl(threads) BuildRequires: perl(threads::shared) BuildRequires: perl(Encode) +BuildRequires: fusioninventory-agent >= 2.2.0 BuildRequires: perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 -Requires: perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 Requires: perl(:MODULE_COMPAT_%(eval "`%{__perl} -V:version`"; echo $version)) +Requires: fusioninventory-agent >= 2.2.0 +Requires: perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 # upstream have rename from SNMPQuery 1.3 to NetInventory 2.0 Obsoletes: perl-FusionInventory-Agent-Task-SNMPQuery < 2.0 @@ -90,6 +92,9 @@ %changelog +* Mon May 14 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 2.1-4 +- add explicit BR/R on fusioninventory-agent + * Fri May 11 2012 Remi Collet <remi@xxxxxxxxxxxxxxxxx> - 2.1-3 - filter private provides/requires - fix description (in sync with upstream) > FIX: Now, you should depend on `FusionInventory-Agent'. +BuildRequires: fusioninventory-agent >= 2.2.0 Ok. $ rpmlint perl-FusionInventory-Agent-Task-NetInventory.spec ../SRPMS/perl-FusionInventory-Agent-Task-NetInventory-2.1-4.fc18.src.rpm ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-4.fc18.noarch.rpm 2 packages and 1 specfiles checked; 0 errors, 0 warnings. rpmlint is Ok. $ rpm -q --requires -p ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-4.fc18.noarch.rpm |sort |uniq -c 1 fusioninventory-agent >= 2.2.0 1 perl(base) 1 perl(constant) 1 perl(Encode) 1 perl(English) 1 perl-FusionInventory-Agent-Task-NetDiscovery >= 2.1 1 perl(:MODULE_COMPAT_5.14.2) 1 perl(strict) 1 perl(threads) 1 perl(threads::shared) 1 perl(warnings) 1 rpmlib(CompressedFileNames) <= 3.0.4-1 1 rpmlib(FileDigests) <= 4.6.0-1 1 rpmlib(PayloadFilesHavePrefix) <= 4.0-1 1 rpmlib(PayloadIsXz) <= 5.2-1 > FIX: Require `FusionInventory-Agent' because it uses modules from that > package. Ok. $ resolvedeps rawhide ../RPMS/noarch/perl-FusionInventory-Agent-Task-NetInventory-2.1-4.fc18.noarch.rpm Binary dependencies resolvable. Ok. Package builds in F18 (http://koji.fedoraproject.org/koji/taskinfo?taskID=4075432). Ok. Package is in line with Fedora and Perl packaging guidelines. Thank your for big patience. The package is much better now. Resolution: Package APPROVED. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review