Please do not reply directly to this email. All additional comments should be made in the comments box of this bug. https://bugzilla.redhat.com/show_bug.cgi?id=819237 Ville Skyttä <ville.skytta@xxxxxx> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED AssignedTo|nobody@xxxxxxxxxxxxxxxxx |ville.skytta@xxxxxx Flag| |fedora-review? --- Comment #5 from Ville Skyttä <ville.skytta@xxxxxx> 2012-05-12 16:00:41 EDT --- Manually stripping the *.so to "solve" the unstripped-binary-or-object warning is definitely the wrong thing to do, instead it needs to be fixed so that rpmbuild's debuginfo extraction takes care of it. That's what I meant in comment 3, see also https://fedoraproject.org/wiki/Packaging:Debuginfo . I suppose there was nothing wrong with the original package (so the stripping should now be just removed), maybe you just didn't have the redhat-rpm-config package installed on your box? I **strongly** suggest using mock to build packages, not a regular user, see https://fedoraproject.org/wiki/Extras/MockTricks . Also, be sure that your box has the fedora-packager package installed, it pulls in various needed things. I personally would not "fix" the incorrect FSF address issue but rather notify upstream about it, see "rpmlint -I incorrect-fsf-address". This is not a blocker though, if you insist. vdr-devel dependency needs to be >= 1.6.0-41 so that the %vdr_* macros are available. I'm not happy with /tmp being the default path due to possibility of insecure temp file issues. The code uses GrabImageFile from VDR's device.c which seems protected against such issues but I'd be more comfortable with it if the default path wasn't world writable, for example %{vdr_cachedir}/screenshot would sound better to me. -- Configure bugmail: https://bugzilla.redhat.com/userprefs.cgi?tab=email ------- You are receiving this mail because: ------- You are on the CC list for the bug. _______________________________________________ package-review mailing list package-review@xxxxxxxxxxxxxxxxxxxxxxx https://admin.fedoraproject.org/mailman/listinfo/package-review